Re: [Qemu-devel] [PATCH v5 0/3] block: commits of snapshots larger than backing files

[Kevin Wolf]

Am 24.01.2014 um 15:02 hat Jeff Cody geschrieben:
> Changes, v4->v5
> 
> Patch 1/3: Update ret in bdrv_commit() (Kevin)
> Patch 2/3: None
> Patch 3/3: None
> 
> [...]
> 
> If a snapshot is larger than a backing file, then the offline bdrv_commit and
> the live active layer commit will fail with an i/o error (usually).  A live
> commit of a non-active layer will complete successfully, as it runs
> bdrv_truncate() on the backing image to resize it to the larger size.
> 
> For both bdrv_commit() and commit_active_start(), this series will resize
> the underlying base image if needed.  If the resize fails, an error will
> be returned.
> 
> 
> Jeff Cody (3):
>   block: resize backing file image during offline commit, if necessary
>   block: resize backing image during active layer commit, if needed
>   block: update block commit documentation regarding image truncation
> 
>  block.c          | 28 +++++++++++++++++++++++++---
>  block/mirror.c   | 38 ++++++++++++++++++++++++++++++++++++++
>  hmp-commands.hx  |  5 +++++
>  qapi-schema.json |  7 +++++++
>  qemu-img.texi    |  7 ++++++-
>  qmp-commands.hx  | 39 +++++++++++++++++++++++++++++++++++++++
>  6 files changed, 120 insertions(+), 4 deletions(-)

Thanks, applied to the block branch.

Kevin