Re: [Qemu-devel] [PATCH v3] Fix QEMU build on OpenBSD on x86 archs

[Brad Smith]

On 02/01/14 2:55 AM, Stefan Hajnoczi wrote:
> On Tue, Dec 10, 2013 at 07:49:08PM -0500, Brad Smith wrote:
> > This resolves the build issue with building the ROMs on OpenBSD on x86 archs.
> > As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the
> > whole OS/packages and so forth. The ROMs need to have PIE disabled. This
> > is my initial attempt at trying to get somehting upstream so that QEMU
> > both builds out of the box and to resolve the build issue with the
> > buildbots that has been around for awhile. We have a patch in our ports
> > tree but it is just the flags hardcoded into the Makefile which obviously
> > is not appropriate for upstream.
> >
> >  From the OpenBSD buildbots..
> >    Building optionrom/multiboot.img
> > ld: multiboot.o: relocation R_X86_64_16 can not be used when making a shared 
> > object; recompile with -fPIC
> >
> > Signed-off by: Brad Smith <address@hidden>
> > ---
> >
> > Change in v2:
> >      * Fix '==' is not portable syntax.
> >
> > Change in v3:
> >      * Rename variables and use compile_prog to detect the presence of the 
> > compiler/linker
> >        flags, as suggested by Stefan Weil.
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>

Is there some sort of process I am missing to have build fixes
commited so that QEMU actually builds?

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.