qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/9] target-arm: Move arm_rmode_to_sf to a share


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 1/9] target-arm: Move arm_rmode_to_sf to a shared location.
Date: Mon, 27 Jan 2014 16:43:56 +0000

On 14 January 2014 16:43, Will Newton <address@hidden> wrote:
> This function will be needed for AArch32 ARMv8 support, so move it to
> helper.c where it can be used by both targets. Also moves the code out
> of line, but as it is quite a large function I don't believe this
> should be a significant performance impact.

Well, it does mean that in the case where you pass the
function a constant input the compiler won't be able
to optimise it down to the correct constant output any
more, but there's only one case where we do that so I
don't think it matters much.

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]