Re: [Qemu-devel] [PATCH v3 06/19] bsd-user: add support for freebsd time related system calls

[Peter Maydell]

On 17 December 2013 11:52, Stacey Son <address@hidden> wrote:
> This change adds support or stubs for time related system calls
> including nanosleep(2), clock_gettime(2), clock_settime(2),
> clock_getres(2), gettimeofday(2), settimeofday(2), adjtime(2),
> ntp_adjtime(2), ntp_gettime(2), utimes(2), lutimes(2), futimes(2),
> futimesat(2), select(2), pselect(2), kqueue(2), kevent(2),
> setitimer(2), getitimer(2), and the undocumented ktimer_*() calls.
> ---
>  bsd-user/Makefile.objs     |    3 +-
>  bsd-user/freebsd/os-time.c |  205 ++++++++++++
>  bsd-user/freebsd/os-time.h |  643 +++++++++++++++++++++++++++++++++++
>  bsd-user/freebsd/qemu-os.h |   53 +++
>  bsd-user/netbsd/os-time.c  |    1 +
>  bsd-user/netbsd/os-time.h  |  179 ++++++++++
>  bsd-user/netbsd/qemu-os.h  |    1 +
>  bsd-user/openbsd/os-time.c |    1 +
>  bsd-user/openbsd/os-time.h |  179 ++++++++++
>  bsd-user/openbsd/qemu-os.h |    1 +
>  bsd-user/syscall.c         |  102 ++++++
>  bsd-user/syscall_defs.h    |  796 
> ++++++++++++++++++++++++++++++++++++++------
>  12 files changed, 2061 insertions(+), 103 deletions(-)

This looks OK on a quick skim though once again
it's more than 2000 lines, whcih suggests it could
profitably be split into more manageable pieces.

thanks
-- PMM