Re: [Qemu-devel] [PATCH v3 00/19] bsd-user: Add system call and mips/arm support.

[Peter Maydell]

On 27 January 2014 19:27, Stacey Son <address@hidden> wrote:
> On Jan 27, 2014, at 1:15 PM, Peter Maydell <address@hidden> wrote:
>> I've been hoping somebody who uses FreeBSD would review
>> these, but since nobody has I'm going to take a look at
>> them. However, I've noticed that none of the patches in
>> this series have Signed-off-by: lines (oddly, since v2
>> and v1 certainly did). We can't apply them at all without
>> those, so you'll need to fix that in your next respin.
>
> I'll generate a new patch set (v4) here in the next day or so.

I've finished my first-pass review of these patches now.
You should probably address my comments before you post a v4.

In general I'd like to see these patches go in (much better
if you're helping to maintain bsd-user in-tree rather than
as a set of separate patches out of tree); however it's
going to be really difficult to get 25000 lines of code
reviewed and committed, especially since we don't have any
active bsd-user developers currently. You need to make the
process as easy as possible for us by making sure all your
patches are easy to review: not too big, and doing just
one thing at once, rather than mixing several changes together.

Looking at this patch series, I think it actually could
use being split into four different series:
 (1) Refactor existing bsd-user code to separate out
     the per-target-arch and per-OS parts
 (2) Add new system calls
 (3) Add ARM target support
 (4) Add MIPS target support

I think you will have much higher chances of success
if you try to get this work reviewed as four separate patch
series than if you submit it all as one enormous series.

thanks
-- PMM