|
From: | Kevin Wolf |
Subject: | Re: [Qemu-devel] [PATCH 08/10] block: Reuse bs->options setting from bdrv_open() |
Date: | Wed, 29 Jan 2014 14:45:16 +0100 |
User-agent: | Mutt/1.5.21 (2010-09-15) |
Am 26.01.2014 um 20:02 hat Max Reitz geschrieben: > Setting bs->options in bdrv_file_open() is not necessary if it is > already done in bdrv_open(). > > Signed-off-by: Max Reitz <address@hidden> Perhaps squash this into patch 7? Because now the reference is created by bdrv_open() instead of bdrv_file_open(). Also my suggestion in a reply to a patch earlier in this series (keeping all option-related code at one place), probably means that it all needs to be done together (or immediately after) handling the NULL options case. Kevin
[Prev in Thread] | Current Thread | [Next in Thread] |