Re: [Qemu-devel] [PATCH v8 08/13] dump: add API to write dump header

[Laszlo Ersek]

On 01/28/14 07:22, qiaonuohan wrote:
> the functions are used to write header of kdump-compressed format to vmcore.
> Header of kdump-compressed format includes:
> 1. common header: DiskDumpHeader32 / DiskDumpHeader64
> 2. sub header: KdumpSubHeader32 / KdumpSubHeader64
> 3. extra information: only elf notes here
> 
> Signed-off-by: Qiao Nuohan <address@hidden>
> Reviewed-by: Laszlo Ersek <address@hidden>
> ---
>  dump.c                |  223 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  include/sysemu/dump.h |   96 +++++++++++++++++++++
>  2 files changed, 319 insertions(+), 0 deletions(-)

Thanks for fixing the four incorrect uses of "dh->block_size" in v7.

Reviewed-by: Laszlo Ersek <address@hidden>