[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: handle "rechs" translation option
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] block: handle "rechs" translation option |
Date: |
Thu, 30 Jan 2014 15:44:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Il 30/01/2014 15:37, Markus Armbruster ha scritto:
Paolo Bonzini <address@hidden> writes:
The rechs translation option is so obscure that we support it but do
"Support" is a rather strong word:
$ git-grep -i rechs
include/hw/block/block.h:#define BIOS_ATA_TRANSLATION_RECHS 4
As Stefan said, all we do is pass the info to the BIOS.
The right way to control IDE geometry translation is ide-hd property
bios-chs-trans. Unfortunately, you missed that one entirely. Have a
gander at bios_chs_trans_table[] in hw/core/qdev-properties.c.
This one is handled by the other series I sent today. That's how I
found it.
We also don't let the user ask for BIOS_ATA_TRANSLATION_LARGE. Its only
source is hd_geometry_guess(). I have no idea whether any user would
want to set it. But that applies to "rechs", too :)
Yeah, you are right that this patch should cover "large" as well. Will
send v2.
Paolo