[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] libcacard: Don't link with all libraries QEMU l
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH] libcacard: Don't link with all libraries QEMU links to |
Date: |
Thu, 30 Jan 2014 16:53:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/30/2014 03:56 PM, Christophe Fergeau wrote:
Acked-by: Alon Levy <address@hidden>
> As described in https://bugzilla.redhat.com/show_bug.cgi?id=987441 ,
> libcacard currently links to all the libraries QEMU is linking to,
> including glusterfs libraries, libiscsi, ... libcacard does not need all of
> these. This patch ensures it's only linked with the libraries it needs.
>
> Signed-off-by: Christophe Fergeau <address@hidden>
> ---
> libcacard/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 4d15da4..6b06448 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -25,7 +25,7 @@ vscclient$(EXESUF): libcacard/vscclient.o libcacard.la
>
> libcacard.la: LDFLAGS += -rpath $(libdir) -no-undefined \
> -export-syms $(SRC_PATH)/libcacard/libcacard.syms
> -libcacard.la: LIBS += $(libcacard_libs)
> +libcacard.la: LIBS = $(libcacard_libs)
> libcacard.la: $(libcacard-lobj-y)
> $(call LINK,$^)
>
>