qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/6] Don't abort on out of memory when creating


From: Orit Wasserman
Subject: Re: [Qemu-devel] [PATCH 5/6] Don't abort on out of memory when creating page cache
Date: Thu, 30 Jan 2014 19:51:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 01/30/2014 05:48 PM, Dr. David Alan Gilbert wrote:
* Orit Wasserman (address@hidden) wrote:
Signed-off-by: Orit Wasserman <address@hidden>
---
  arch_init.c  | 16 ++++++++++++++--
  page_cache.c | 18 ++++++++++++++----
  2 files changed, 28 insertions(+), 6 deletions(-)

diff --git a/arch_init.c b/arch_init.c
index 5eff80b..806d096 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -664,8 +664,20 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
              DPRINTF("Error creating cache\n");
              return -1;
          }
-        XBZRLE.encoded_buf = g_malloc0(TARGET_PAGE_SIZE);
-        XBZRLE.current_buf = g_malloc(TARGET_PAGE_SIZE);
+
+        /* We prefer not to abort if there is no memory */
+        XBZRLE.encoded_buf = g_try_malloc0(TARGET_PAGE_SIZE);
+        if (!XBZRLE.encoded_buf) {
+            DPRINTF("Error allocating encoded_buf\n");
+            return -1;
+        }
+
+        XBZRLE.current_buf = g_try_malloc(TARGET_PAGE_SIZE);
+        if (!XBZRLE.current_buf) {
+            DPRINTF("Error allocating current_buf\n");
+            return -1;
+        }

Would it be best to free encoded_buf in this second exit case?


It is freed in migration_end (that is called when migration fails or canceled).

Orit

Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK





reply via email to

[Prev in Thread] Current Thread [Next in Thread]