Re: [Qemu-devel] [PATCH 06/42] input: qapi: define event types

[Eric Blake]

On 01/28/2014 02:56 AM, Gerd Hoffmann wrote:
> Define input event types, using qapi.  So we get nicely autogenerated
> types for our input events.  And when it comes to qmp support some day
> things will be alot easier.

s/alot/a lot/

> 
> Types are modeled after the linux input layer.  There are separate
> event types for each value.  There is a sync to indicate the end
> of a event group.
> 
> Mouse events are splitted into motion events (one for each axis) and

s/splitted/split/

> button events, which are grouped by sync.
> 
> Keyboard events are using the existing KeyValue type.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  qapi-schema.json | 76 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 76 insertions(+)

> +
> +##
> +# @InputBtnEvent

Should we spell this out?  I'm okay with the abbreviation if it makes it
easier to fit 80 columns, but Button is nicer to read than Btn.

> +
> +##
> +# @InputEvent
> +#
> +# Input event union.
> +#
> +# Since: 2.0
> +##
> +{ 'union' : 'InputEvent',
> +  'data'  : { 'key'     : 'InputKeyEvent',
> +              'btn'     : 'InputBtnEvent',

Again, should we use 'button' instead of 'btn'?

As naming is cosmetic, I can live with what you have.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature