[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary |
|
Date: |
Fri, 31 Jan 2014 08:42:22 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Andreas Färber <address@hidden> writes:
> Am 30.01.2014 15:07, schrieb Markus Armbruster:
>> error_is_set(&var) is the same as var != NULL, but it takes
>> whole-program analysis to figure that out. Unnecessarily hard for
>> optimizers, static checkers, and human readers. Dumb it down to
>> obvious.
>>
>> Gets rid of several dozen Coverity false positives.
>>
>> Note that the obvious form is already used in many places.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>
> Reviewed-by: Andreas Färber <address@hidden>
Thanks!
> I don't suppose you used a Coccinelle script that we could re-run in the
> future? ;)
Perhaps I should've, but since the job was simple enough for
M-x tags-query-replace...
> Via QMP queue?
Yes, please.