[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] block: handle "rechs" and "large" translatio
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] block: handle "rechs" and "large" translation options |
|
Date: |
Fri, 31 Jan 2014 09:07:34 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> Sure, CHS translation is an obscure topic, and legacy options for
> hard-disk geometries are obscure as well. But since QEMU does nothing
> with it except telling the BIOS, and since there "large" and "rechs"
> are listed in the enums, parsing them seems to be the bare minimum.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
This is semantically on top of "[PATCH 00/12] qdev: cleanup legacy
properties", which adds these two values to isa-hd property
bios-chs-trans. Here, you add them to the two obsolete ways to specify
the property. While I don't think that's necessary, I don't object to
it either.
Despite my doubts on the need for the patch:
Reviewed-by: Markus Armbruster <address@hidden>