[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [uq/master PATCH 7/7] target-i386: CPU model subclasses
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [uq/master PATCH 7/7] target-i386: CPU model subclasses |
Date: |
Fri, 31 Jan 2014 15:20:12 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jan 30, 2014 at 05:48:59PM -0200, Eduardo Habkost wrote:
> Register separate QOM classes for each x86 CPU model.
>
> This will allow management code to more easily probe what each CPU model
> provides, by simply creating objects using the appropriate class name,
> without having to restart QEMU.
>
> This also allows us to eliminate the qdev_prop_set_globals_for_type()
> hack to set CPU-model-specific global properties.
>
> Instead of creating separate class_init functions for each class, I just
> used class_dat to store a pointer to the X86CPUDefinition struct for
> each CPU model. This should make the patch shorter and easier to review.
> Later we can gradually convert each X86CPUDefinition field to lists of
> per-class property defaults.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> This version is closer to the version sent by Andrea and then later
> resubmitted by Igor as "[RFC v5] target-i386: Slim conversion to X86CPU
> subclasses + KVM subclasses", as it doesn't create one new class_init
> function for each subclass. One main difference is that this version
> does not use KVM-specific subclasses, to keep things simpler.
I will submit a new version of this patch later, as I will:
* Split some changes that can be made in a separate patch, after
the conversion (the x86_cpudef_setup() removal and the CPU listing
code);
* Add proper attribution to Andreas and Igor, who wrote
"[RFC v5] target-i386: Slim conversion to X86CPU subclasses + KVM
subclasses".
--
Eduardo
- [Qemu-devel] [uq/master PATCH 3/7] target-i386: Move KVM default-vendor hack to instance_init, (continued)
- [Qemu-devel] [uq/master PATCH 3/7] target-i386: Move KVM default-vendor hack to instance_init, Eduardo Habkost, 2014/01/30
- [Qemu-devel] [uq/master PATCH 2/7] target-i386: Don't change x86_def_t struct on cpu_x86_register(), Eduardo Habkost, 2014/01/30
- [Qemu-devel] [uq/master PATCH 4/7] target-i386: Rename cpu_x86_register() to x86_cpu_load_def(), Eduardo Habkost, 2014/01/30
- [Qemu-devel] [uq/master PATCH 5/7] target-i386: Call x86_cpu_load_def() earlier, Eduardo Habkost, 2014/01/30
- [Qemu-devel] [uq/master PATCH 6/7] target-i386: Rename x86_def_t to X86CPUDefinition, Eduardo Habkost, 2014/01/30
- [Qemu-devel] [uq/master PATCH 7/7] target-i386: CPU model subclasses, Eduardo Habkost, 2014/01/30
- Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7, Paolo Bonzini, 2014/01/30
- Re: [Qemu-devel] [uq/master PATCH 0/7] x86 CPU subclasses, take 7, Igor Mammedov, 2014/01/31