[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr |
Date: |
Sat, 1 Feb 2014 18:00:01 +0000 |
On 20 January 2014 19:34, Michael Walle <address@hidden> wrote:
> Do not use qemu_log().
>
> Signed-off-by: Michael Walle <address@hidden>
> ---
> hw/misc/lm32_sys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c
> index 8176cdb..6af0cca 100644
> --- a/hw/misc/lm32_sys.c
> +++ b/hw/misc/lm32_sys.c
> @@ -80,7 +80,7 @@ static void sys_write(void *opaque, hwaddr addr,
> case R_PASSFAIL:
> s->regs[addr] = value;
> testname = (char *)s->testname;
> - qemu_log("TC %-32s %s\n", testname, (value) ? "FAILED" : "OK");
> + fprintf(stderr, "TC %-32s %s\n", testname, (value) ? "FAILED" :
> "OK");
> break;
This looks wrong to me -- devices shouldn't print to stderr, ideally.
thanks
-- PMM
- Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr,
Peter Maydell <=