Re: [Qemu-devel] [RFC PATCH v2] Add option to switch off FDC

[Michael S. Tsirkin]

On Fri, Jan 31, 2014 at 12:39:01PM -0700, Eric Blake wrote:
> On 01/31/2014 12:03 PM, Gabriel L. Somlo wrote:
> > Allow guests to omit the configuration of a floppy disk controller.
> > 
> > Signed-off-by: Gabriel Somlo <address@hidden>
> > ---
> > 
> > New in this version:
> > 
> >   - "int have_fdc = 1;" instead of "int no_fdc = 0;"
> > 
> >   - use 8bit field for FDC0's _STA method
> > 
> 
> > 
> > Are we OK with the "mechanism" part, i.e. introducing "have_fdc", and
> > programatically configuring the FDC in pc.c and patching the DSDT
> > based on its value ?
> > 
> 
> >  
> > +DEF("no-fdc", 0, QEMU_OPTION_no_fdc,
> > +    "-no-fdc         disable FDC\n", QEMU_ARCH_I386)
> > +STEXI
> > address@hidden -no-fdc
> > address@hidden -no-fdc
> > +Disable FDC support.
> > +ETEXI
> 
> This is not discoverable via the current state of QMP.  It also has the
> annoyance of being a one-way switch with no way to revert to a default
> state.  Can you make this instead use qemuOpts (maybe looking like '-fdc
> yes' vs. '-fdc no')?

I think Marcel said he's working on an infrastructure to add global
options as machine properties.

> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>