Re: [Qemu-devel] [PATCH v4 0/4] Create ARM KVM VGIC with device control API

[Christoffer Dall]

On Fri, Jan 31, 2014 at 02:21:42PM +0000, Peter Maydell wrote:
> On 29 January 2014 13:21, Peter Maydell <address@hidden> wrote:
> > On 28 January 2014 20:28, Christoffer Dall <address@hidden> wrote:
> >> This patch series adds generic support for issuing device control
> >> related ioctls and supports creating the ARM KVM-accelerated VGIC using
> >> the device control API while maintaining backwards compatibility for
> >> older kernels.
> >>
> >> Changelogs in the individual patches.
> >
> > Thanks, applied to target-arm.next. Git complains about trailing
> > whitespace in the kernel header patch; dunno if you care about
> > fixing that kind of thing in the kernel upstream.
> 
> I slightly belatedly discovered that these patches break
> the build on aarch64 hosts, because your new kernel defines
> only exist in the arm KVM headers and not the arm64 ones:
> 
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/intc/arm_gic_kvm.c: In
> function 'kvm_arm_gic_realize':
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/intc/arm_gic_kvm.c:141:29:
> error: 'KVM_DEV_ARM_VGIC_GRP_ADDR' undeclared (first use in this
> function)
> /home/petmay01/linaro/qemu-from-laptop/qemu/hw/intc/arm_gic_kvm.c:141:29:
> note: each undeclared identifier is reported only once for each
> function it appears in
> 
> I've dropped the patches from target-arm.next. The
> simplest fix is probably to get the arm64 headers to
> also support this API and then resubmit.
> 
Yikes! Yeah, it also breaks the build of arm64 kernels with KVM enabled,
better get this fix upstream fast.  Thanks for spotting it!

-Christoffer