qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] Use g_new() & friends where that makes obvi


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 0/2] Use g_new() & friends where that makes obvious sense
Date: Mon, 3 Feb 2014 09:11:56 +0000

On 3 February 2014 08:40, Markus Armbruster <address@hidden> wrote:
> Peter Maydell <address@hidden> writes:
>> On 31 January 2014 15:53, Markus Armbruster <address@hidden> wrote:
>>>  186 files changed, 376 insertions(+), 415 deletions(-)
>>
>> No objection in principle, but I think this is going to be
>> hideous merge pain since it touches a huge range of files.
>> Could you split it up into separate patches that could
>> reasonably go in via the appropriate submaintainer trees?
>
> No merge pain at all if you simply rerun the included Coccinelle patch!

Yes, but that requires me to find, install, learn about and use
Coccinelle.

> Splitting the patch may shift some pain from the choke point (you) to
> submaintainers and me.  I don't mind the splitting pain.  I do mind the
> "chase the nominal maintainer of obscure corner" pain.
>
> If you really want it split: what about splitting off just the busy
> and/or well-maintained subsystems?

Yes, that's fine. You can put the "miscellaneous leftovers" parts
through trivial if you like. I just dislike single touches-entire-world
patches if they're not absolutely necessary.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]