[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 1/5] pcihp: replace enable|disable_device() with
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH v4 1/5] pcihp: replace enable|disable_device() with oneliners |
Date: |
Mon, 3 Feb 2014 11:44:57 +0100 |
enable_device() and disable_device() functions aren't reused anywere,
so replace them with respective oneliners at call sites.
Signed-off-by: Igor Mammedov <address@hidden>
---
hw/acpi/pcihp.c | 14 ++------------
1 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index 4345f5d..464739a 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -177,16 +177,6 @@ void acpi_pcihp_reset(AcpiPciHpState *s)
acpi_pcihp_update(s);
}
-static void enable_device(AcpiPciHpState *s, unsigned bsel, int slot)
-{
- s->acpi_pcihp_pci_status[bsel].up |= (1U << slot);
-}
-
-static void disable_device(AcpiPciHpState *s, unsigned bsel, int slot)
-{
- s->acpi_pcihp_pci_status[bsel].down |= (1U << slot);
-}
-
int acpi_pcihp_device_hotplug(AcpiPciHpState *s, PCIDevice *dev,
PCIHotplugState state)
{
@@ -204,9 +194,9 @@ int acpi_pcihp_device_hotplug(AcpiPciHpState *s, PCIDevice
*dev,
}
if (state == PCI_HOTPLUG_ENABLED) {
- enable_device(s, bsel, slot);
+ s->acpi_pcihp_pci_status[bsel].up |= (1U << slot);
} else {
- disable_device(s, bsel, slot);
+ s->acpi_pcihp_pci_status[bsel].down |= (1U << slot);
}
return 0;
--
1.7.1
- [Qemu-devel] [PATCH v4 0/5] pc: make ACPI pcihp more reusable, Igor Mammedov, 2014/02/03
- [Qemu-devel] [PATCH v4 1/5] pcihp: replace enable|disable_device() with oneliners,
Igor Mammedov <=
- [Qemu-devel] [PATCH v4 2/5] pcihp: make PCI hotplug mmio handlers indifferent to PCI_HOTPLUG_ADDR, Igor Mammedov, 2014/02/03
- [Qemu-devel] [PATCH v4 3/5] pcihp: make pci_read() mmio calback compatible with legacy ACPI hotplug, Igor Mammedov, 2014/02/03
- [Qemu-devel] [PATCH v4 4/5] pcihp: remove unused AcpiPciHpPciStatus.device_present field, Igor Mammedov, 2014/02/03
- [Qemu-devel] [PATCH v4 5/5] hw:piix4:acpi: reuse pcihp code for legacy PCI hotplug, Igor Mammedov, 2014/02/03
- Re: [Qemu-devel] [PATCH v4 0/5] pc: make ACPI pcihp more reusable, Michael S. Tsirkin, 2014/02/03