Re: [Qemu-devel] [PATCH 1/6] cris: Add a CRISv32 default "any" CPU for user mode emulation

[Edgar E. Iglesias]

On Mon, Feb 03, 2014 at 12:44:03PM +0100, Andreas Färber wrote:
> Hi,
> 
> Am 02.02.2014 04:04, schrieb address@hidden:
> > From: "Edgar E. Iglesias" <address@hidden>
> > 
> > Signed-off-by: Edgar E. Iglesias <address@hidden>
> > ---
> >  target-cris/cpu.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/target-cris/cpu.c b/target-cris/cpu.c
> > index 44301a4..21f1860 100644
> > --- a/target-cris/cpu.c
> > +++ b/target-cris/cpu.c
> > @@ -239,7 +239,14 @@ static const TypeInfo cris_cpu_model_type_infos[] = {
> >          .name = TYPE("crisv32"),
> >          .parent = TYPE_CRIS_CPU,
> >          .class_init = crisv32_cpu_class_init,
> > +    },
> > +#if defined(CONFIG_USER_ONLY)
> > +    {
> > +        .name = TYPE("any"),
> > +        .parent = TYPE_CRIS_CPU,
> > +        .class_init = crisv32_cpu_class_init,
> >      }
> 
> If this model is supposed to be exactly the same as crisv32, I would
> recommend to make this an alias handled in CRISCPU::class_by_name()
> rather than a distinct QOM type.
> 

Sounds good, I'll send a v2 of this one.

Cheers,
Edgar