Re: [Qemu-devel] [PATCH] block: Fail gracefully with missing filename

[Stefan Hajnoczi]

On Mon, Feb 03, 2014 at 02:55:31PM +0100, Kevin Wolf wrote:
> This fixes a regression introduced in commit 2a05cbe42 ('block: Allow
> block devices without files'):
> 
> $ qemu-system-x86_64 -drive driver=file
> qemu-system-x86_64: block.c:892: bdrv_open_common: Assertion
> `!drv->bdrv_needs_filename || filename != ((void *)0)' failed.
> 
> Now the respective check must be performed not only in bdrv_file_open(),
> but also in bdrv_open().
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c                    | 11 ++++++-----
>  tests/qemu-iotests/051     | 12 ++++++++++++
>  tests/qemu-iotests/051.out | 24 ++++++++++++++++++++++++
>  3 files changed, 42 insertions(+), 5 deletions(-)

Ouch!  Nice to have tests that protect us in the future.

Reviewed-by: Stefan Hajnoczi <address@hidden>