Re: [Qemu-devel] [PATCH] block/iscsi: always fill bs->bl.opt_transfer_length

[Kevin Wolf]

Am 29.01.2014 um 16:36 hat Benoît Canet geschrieben:
> Le Wednesday 29 Jan 2014 à 13:03:35 (+0100), Peter Lieven a écrit :
> > the opt_transfer_length has nothing to do with logical
> > block provisioning stuff so always copy it from
> > the block limits VPD page.
> > 
> > Reported-By: Benoit Canet <address@hidden>
> > Signed-off-by: Peter Lieven <address@hidden>
> > ---
> >  block/iscsi.c |    5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/block/iscsi.c b/block/iscsi.c
> > index 38b07f8..3c0b728 100644
> > --- a/block/iscsi.c
> > +++ b/block/iscsi.c
> > @@ -1331,10 +1331,9 @@ static int iscsi_refresh_limits(BlockDriverState *bs)
> >          }
> >          bs->bl.write_zeroes_alignment = 
> > sector_lun2qemu(iscsilun->bl.opt_unmap_gran,
> >                                                          iscsilun);
> > -
> > -        bs->bl.opt_transfer_length = 
> > sector_lun2qemu(iscsilun->bl.opt_xfer_len,
> > -                                                     iscsilun);
> >      }
> > +    bs->bl.opt_transfer_length = sector_lun2qemu(iscsilun->bl.opt_xfer_len,
> > +                                                 iscsilun);
> >      return 0;
> >  }
> >  
> > -- 
> > 1.7.9.5
> > 
> Reviewed-by: Benoit Canet <address@hidden>

Thanks, applied to the block branch.

Kevin