[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support |
|
Date: |
Mon, 3 Feb 2014 21:35:56 +0000 |
On 3 February 2014 21:27, Richard Henderson <address@hidden> wrote:
> On 02/01/2014 10:16 AM, Peter Maydell wrote:
>> This looks at least superficially OK, but I'm not really familiar
>> with QEMU's breakpoint/watchpoint support code. RTH: do
>> you want to have a look over this one?
>
> It's copied verbatim from the i386 port, missing braces and all.
> So it certainly passes the sniff test.
That sounds like we ought to be generalising our support
code for bp/wp support in targets. Maybe I'll do that if/when
I ever implement bp/wp support for ARM :-)
thanks
-- PMM