[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size |
Date: |
Tue, 04 Feb 2014 09:26:29 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 02/04/2014 08:19 AM, Juan Quintela wrote:
> From: Orit Wasserman <address@hidden>
>
> Signed-off-by: Orit Wasserman <address@hidden>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> migration.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/migration.c b/migration.c
> index 46a7305..25add6f 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error
> **errp)
> return;
> }
>
> + /* Cache should not be larger than guest ram size */
> + if (value > ram_bytes_total()) {
> + error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size",
> + "exceeds guest ram size ");
Trailing space in the error message.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 0/8] migration queue, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 8/8] exec: fix ram_list dirty map optimization, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 4/8] migration:fix free XBZRLE decoded_buf wrong, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 6/8] Don't abort on out of memory when creating page cache, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 7/8] Don't abort on memory allocation error, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size, Juan Quintela, 2014/02/04
- Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size,
Eric Blake <=
- [Qemu-devel] [PATCH 3/8] Add check for cache size smaller than page size, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 1/8] vmstate: Make VMSTATE_STRUCT_POINTER take type, not ptr-to-type, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 2/8] Set xbzrle buffers to NULL after freeing them to avoid double free errors, Juan Quintela, 2014/02/04
- Re: [Qemu-devel] [PULL 0/8] migration queue, Juan Quintela, 2014/02/04