[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] xen_disk: add discard support
From: |
Olaf Hering |
Subject: |
Re: [Qemu-devel] [PATCH] xen_disk: add discard support |
Date: |
Tue, 4 Feb 2014 17:51:15 +0100 |
User-agent: |
Mutt/1.5.22.rev6346 (2013-10-29) |
On Tue, Feb 04, Kevin Wolf wrote:
> Now you call bdrv_acct_done() in the callback without having a matching
> bdrv_acct_start(). You need to make it conditional in the callback.
I see.
Stefano,
Is ioreq_runio_qemu_aio symetric in this regard anyway? In case of
BLKIF_OP_WRITE|BLKIF_OP_FLUSH_DISKCACHE and no ioreq->req.nr_segments
then qemu_aio_complete is called anyway. Will qemu_aio_complete get down
to the bdrv_acct_done call at all in this case?
Olaf