[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/8] exec: fix ram_list dirty map optimization
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 2/8] exec: fix ram_list dirty map optimization |
Date: |
Tue, 4 Feb 2014 16:55:28 +0100 |
From: Alexey Kardashevskiy <address@hidden>
The ae2810c4bb3b383176e8e1b33931b16c01483aab patch introduced
optimization for ram_list.dirty_memory update. However it can only
work correctly if hpratio is 1 as the @bitmap parameter stores 1 bits
per system page size (may vary, 4K or 64K on PPC64) and
ram_list.dirty_memory stores 1 bit per TARGET_PAGE_SIZE
(which is hardcoded to 4K).
This fixes hpratio!=1 case to fall back to the slow path.
Signed-off-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
include/exec/ram_addr.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/exec/ram_addr.h b/include/exec/ram_addr.h
index 481a447..2edfa96 100644
--- a/include/exec/ram_addr.h
+++ b/include/exec/ram_addr.h
@@ -93,7 +93,8 @@ static inline void
cpu_physical_memory_set_dirty_lebitmap(unsigned long *bitmap,
unsigned long page = BIT_WORD(start >> TARGET_PAGE_BITS);
/* start address is aligned at the start of a word? */
- if (((page * BITS_PER_LONG) << TARGET_PAGE_BITS) == start) {
+ if ((((page * BITS_PER_LONG) << TARGET_PAGE_BITS) == start) &&
+ (hpratio == 1)) {
long k;
long nr = BITS_TO_LONGS(pages);
--
1.8.5.3
- [Qemu-devel] [PULL v2 0/8] migration queue, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 7/8] Don't abort on out of memory when creating page cache, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 6/8] XBZRLE cache size should not be larger than guest memory size, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 3/8] Set xbzrle buffers to NULL after freeing them to avoid double free errors, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 5/8] migration:fix free XBZRLE decoded_buf wrong, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 1/8] vmstate: Make VMSTATE_STRUCT_POINTER take type, not ptr-to-type, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 2/8] exec: fix ram_list dirty map optimization,
Juan Quintela <=
- [Qemu-devel] [PATCH 4/8] Add check for cache size smaller than page size, Juan Quintela, 2014/02/04
- [Qemu-devel] [PATCH 8/8] Don't abort on memory allocation error, Juan Quintela, 2014/02/04
- Re: [Qemu-devel] [PULL v2 0/8] migration queue, Peter Maydell, 2014/02/08