[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v5 05/12] milkymist-vgafb: swap pixel data in source
From: |
Michael Walle |
Subject: |
[Qemu-devel] [PULL v5 05/12] milkymist-vgafb: swap pixel data in source buffer |
Date: |
Tue, 4 Feb 2014 19:58:27 +0100 |
In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was
eliminated. But we are reading from the target buffer a 16-bit value, which
is in big-endian format. Therefore, use lduw_be_p() to read the value.
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Michael Walle <address@hidden>
---
hw/display/milkymist-vgafb_template.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/milkymist-vgafb_template.h
b/hw/display/milkymist-vgafb_template.h
index e0036e1..4883780 100644
--- a/hw/display/milkymist-vgafb_template.h
+++ b/hw/display/milkymist-vgafb_template.h
@@ -61,7 +61,7 @@ static void glue(draw_line_, BITS)(void *opaque, uint8_t *d,
const uint8_t *s,
uint8_t r, g, b;
while (width--) {
- memcpy(&rgb565, s, sizeof(rgb565));
+ rgb565 = lduw_be_p(s);
r = ((rgb565 >> 11) & 0x1f) << 3;
g = ((rgb565 >> 5) & 0x3f) << 2;
b = ((rgb565 >> 0) & 0x1f) << 3;
--
1.7.10.4
- [Qemu-devel] [PULL v5 00/12] target-lm32 updates, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write(), Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 02/12] tests: lm32: new rule for single test cases, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 12/12] hw/lm32: print error if cpu model is not found, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 06/12] target-lm32: kill cpu_abort() calls, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 04/12] lm32_uart/lm32_juart: use qemu_chr_fe_write_all(), Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 09/12] lm32_sys: print test result on stderr, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 11/12] target-lm32: stop VM on illegal or unknown instruction, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 08/12] target-lm32: add breakpoint/watchpoint support, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 05/12] milkymist-vgafb: swap pixel data in source buffer,
Michael Walle <=
- [Qemu-devel] [PULL v5 10/12] lm32_sys: dump cpu state if test case fails, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 01/12] lm32_sys: increase test case name length limit, Michael Walle, 2014/02/04
- [Qemu-devel] [PULL v5 07/12] target-lm32: move model features to LM32CPU, Michael Walle, 2014/02/04
- Re: [Qemu-devel] [PULL v5 00/12] target-lm32 updates, Peter Maydell, 2014/02/08