qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 2/4] util/fifo8: clear fifo head upon reset


From: Peter Crosthwaite
Subject: Re: [Qemu-devel] [PATCH v5 2/4] util/fifo8: clear fifo head upon reset
Date: Wed, 5 Feb 2014 15:28:37 +1000

On Fri, Jan 31, 2014 at 8:02 AM, Beniamino Galvani <address@hidden> wrote:
> To improve the predictability of fifo8_pop_buf(), the fifo head is set
> to start of data buffer upon a reset so that the first call to the

A nit:

"the start of the"

> function will be able to retrieve all data in the fifo.
>
> Signed-off-by: Beniamino Galvani <address@hidden>

Reviewed-by: Peter Crosthwaite <address@hidden>

Thanks for your contributions.

Regards,
Peter

> ---
>  util/fifo8.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/util/fifo8.c b/util/fifo8.c
> index a7503c2..6a43482 100644
> --- a/util/fifo8.c
> +++ b/util/fifo8.c
> @@ -89,6 +89,7 @@ const uint8_t *fifo8_pop_buf(Fifo8 *fifo, uint32_t max, 
> uint32_t *num)
>  void fifo8_reset(Fifo8 *fifo)
>  {
>      fifo->num = 0;
> +    fifo->head = 0;
>  }
>
>  bool fifo8_is_empty(Fifo8 *fifo)
> --
> 1.7.10.4
>
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]