[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/10] tests/qapi-schema: Cover union types with
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 06/10] tests/qapi-schema: Cover union types with base |
Date: |
Thu, 06 Feb 2014 19:40:11 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 02/06/2014 07:29 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/qapi-schema/qapi-schema-test.json | 1 +
> tests/qapi-schema/qapi-schema-test.out | 2 +-
> tests/test-qmp-input-strict.c | 4 ++--
> tests/test-qmp-input-visitor.c | 3 ++-
> tests/test-qmp-output-visitor.c | 2 ++
> 5 files changed, 8 insertions(+), 4 deletions(-)
>
> - OrderedDict([('union', 'UserDefUnion'), ('data', OrderedDict([('a',
> 'UserDefA'), ('b', 'UserDefB')]))]),
> + OrderedDict([('union', 'UserDefUnion'), ('base', 'UserDefZero'), ('data',
> OrderedDict([('a', 'UserDefA'), ('b', 'UserDefB')]))]),
> OrderedDict([('union', 'UserDefAnonUnion'), ('discriminator',
> OrderedDict()), ('data', OrderedDict([('uda', 'UserDefA'), ('s', 'str'),
> ('i', 'int')]))]),
> OrderedDict([('union', 'UserDefNativeListUnion'), ('data',
> OrderedDict([('integer', ['int']), ('s8', ['int8']), ('s16', ['int16']),
> ('s32', ['int32']), ('s64', ['int64']), ('u8', ['uint8']), ('u16',
> ['uint16']), ('u32', ['uint32']), ('u64', ['uint64']), ('number',
> ['number']), ('boolean', ['bool']), ('string', ['str'])]))]),
Good, we still have coverage of a union without a base.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/10] qapi: Test coverage & clean up generated code, Markus Armbruster, 2014/02/06
- [Qemu-devel] [PATCH 07/10] tests/qapi-schema: Cover flat union types, Markus Armbruster, 2014/02/06
- [Qemu-devel] [PATCH 01/10] tests/qapi-schema: Actually check successful QMP command response, Markus Armbruster, 2014/02/06
- [Qemu-devel] [PATCH 03/10] tests/qapi-schema: Cover simple argument types, Markus Armbruster, 2014/02/06
- [Qemu-devel] [PATCH 06/10] tests/qapi-schema: Cover union types with base, Markus Armbruster, 2014/02/06
- Re: [Qemu-devel] [PATCH 06/10] tests/qapi-schema: Cover union types with base,
Eric Blake <=
- [Qemu-devel] [PATCH 05/10] tests/qapi-schema: Cover complex types with base, Markus Armbruster, 2014/02/06
- [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors, Markus Armbruster, 2014/02/06