qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 07/10] tests/qapi-schema: Cover flat union types


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 07/10] tests/qapi-schema: Cover flat union types
Date: Thu, 06 Feb 2014 19:51:38 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 02/06/2014 07:29 AM, Markus Armbruster wrote:
> The test demonstrates a generator bug: the generated struct
> UserDefFlatUnion doesn't include members for the indirect base
> UserDefZero.

Good catch.

> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  tests/qapi-schema/qapi-schema-test.json |  7 +++++++
>  tests/qapi-schema/qapi-schema-test.out  |  2 ++
>  tests/test-qmp-input-strict.c           | 33 
> +++++++++++++++++++++++++++++++++
>  tests/test-qmp-input-visitor.c          | 20 ++++++++++++++++++++
>  tests/test-qmp-output-visitor.c         | 31 +++++++++++++++++++++++++++++++
>  5 files changed, 93 insertions(+)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]