[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCH v18 00/10] Shared library module support |
Date: |
Fri, 07 Feb 2014 12:14:00 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 |
07.02.2014 11:13, Paolo Bonzini wrote:
> Il 07/02/2014 01:06, Peter Maydell ha scritto:
>> Why do we need OS specific code to do this when the code
>> in vl.c for getting the executable path to use as a base for
>> finding bios blobs works fine without OS specific code?
>
> That's because right now module_call_init is not receiving an argv[0] to pass
> to qemu_exec_dir (os_find_datadir has an argument for that). It can be fixed
> (in the whole call chain, including e.g. bdrv_init/bdrv_init_with_whitelist).
We can add a global variable (either executable_dir or whole -L path),
init it in vl.c as we do now, and use it in other places in a uniform
way.
BTW, It'd be really good to have a separate, arch-specific directory for
the plugins, like /usr/lib/x86_64-linux-gnu/qemu/, so it will be
multiarch-able. But it is not really a show-stopper.
Thanks,
/mjt