Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest

[Stefan Hajnoczi]

On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas Färber wrote:
> +#include "libqtest.h"
> +
> +#include <glib.h>
> +#include <string.h>
> +#include "qemu/osdep.h"

Please put <system.h> includes before "user.h" includes.  That way we
can be sure our macros don't mess up system headers.

> +
> +static void nop(void)
> +{
> +}

I suggest a comment here to explain the point of this test:
/* The point of this test case is just to instantiate the device */