[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative va
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values |
|
Date: |
Fri, 7 Feb 2014 22:45:37 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 07.02.2014 um 17:27 hat Eric Blake geschrieben:
> On 02/07/2014 09:12 AM, Kevin Wolf wrote:
> > The behaviour of the ROUND_UP macro with negative numbers isn't obvious.
> > It happens to do the right thing in this please, but better avoid it.
>
> s/please/place/
Indeed... Thanks, fixed it locally.
> > Suggested-by: Laszlo Ersek <address@hidden>
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > block.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Series: Reviewed-by: Eric Blake <address@hidden>
Kevin
pgpOhqVmgSZEn.pgp
Description: PGP signature