[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative va
|
From: |
Laszlo Ersek |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values |
|
Date: |
Sat, 08 Feb 2014 00:24:24 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131118 Thunderbird/17.0.11 |
On 02/07/14 22:45, Kevin Wolf wrote:
> Am 07.02.2014 um 17:27 hat Eric Blake geschrieben:
>> On 02/07/2014 09:12 AM, Kevin Wolf wrote:
>>> The behaviour of the ROUND_UP macro with negative numbers isn't obvious.
>>> It happens to do the right thing in this please, but better avoid it.
>>
>> s/please/place/
>
> Indeed... Thanks, fixed it locally.
>
>>> Suggested-by: Laszlo Ersek <address@hidden>
>>> Signed-off-by: Kevin Wolf <address@hidden>
>>> ---
>>> block.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Series: Reviewed-by: Eric Blake <address@hidden>
Not necessary after Eric's review, but here it is anyway:
series
Reviewed-by: Laszlo Ersek <address@hidden>
Thanks!
Laszlo