Re: [Qemu-devel] [PULL 16/16] target-i386: Move KVM default-vendor hack to instance_init

[Eduardo Habkost]

On Sun, Feb 09, 2014 at 12:10:20AM +0000, Peter Maydell wrote:
> On 8 February 2014 23:33, Paolo Bonzini <address@hidden> wrote:
> > Il 08/02/2014 18:28, Andreas Färber ha scritto:
> >> Since when is it OK to declare variables in the middle of the block?
> 
> > When the code looks better, it is OK since always: checkpatch.pl doesn't
> > complain and -Wdeclaration-after-statement is not added to the compiler
> > flags.
> 
> Huh? checkpatch is notoriously not a reliable guide, and we've had
> the "declarations at start of block" rule since forever.

Sorry for my confusion, but I was not aware of that rule, and I don't
know what I should use as a guide, if checkpatch.pl and CODING_STYLE are
not enough. Is there additional coding style documentation or scripts I
should look at?

-- 
Eduardo