[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro |
Date: |
Sun, 09 Feb 2014 13:49:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 09.02.2014 02:53, schrieb Peter Crosthwaite:
> On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber <address@hidden> wrote:
>> Use type-specific QOM cast macros instead.
>>
>
> Should be past tense - "We now use type-specific ...". The imperative
> form of "use" suggests you are making the change in this patch but you
> have already done it.
It was meant as a guidance for resolving conflicts due to lack of that
macro, not as a description of past patches. I've adopted your wording.
>> Signed-off-by: Andreas Färber <address@hidden>
>
> Reviewed-by: Peter Crosthwaite <address@hidden>
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg