Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

[Andreas Färber]

Hi,

Am 08.02.2014 17:38, schrieb Mark Cave-Ayland:
> +static Property cg3_properties[] = {
> +    DEFINE_PROP_HEX32("vram_size",     CG3State, vram_size, -1),

Paolo is about to drop hex32 ...

> +    DEFINE_PROP_UINT16("width",        CG3State, width,     -1),
> +    DEFINE_PROP_UINT16("height",       CG3State, height,    -1),
> +    DEFINE_PROP_UINT16("depth",        CG3State, depth,     -1),
> +    DEFINE_PROP_HEX64("prom_addr",     CG3State, prom_addr, -1),

...and hex64 types. Please use UINT32 and UINT64 instead.

> +    DEFINE_PROP_END_OF_LIST(),
> +};

And as far as QOM and style is concerned, please don't use TCX as excuse
to do things the old way. If you feel you need consistency, feel free to
clean up TCX, but we only require it for new patches. Otherwise no
progress would be possible within the code base.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg