|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 09/20] cow: correctly propagate errors |
Date: | Mon, 10 Feb 2014 09:28:00 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Il 10/02/2014 09:04, Fam Zheng ha scritto:
I'm never sure about choice of using local_err with error_propagate, or straightly pass errp, but the logic still looks right to me, so,
Basically, never use error_is_set. If you do, you probably should have used instead &local_err and error_propagate. If you are not using error_is_set, it's fine to use errp directly with no error_propagate.
Paolo
Reviewed-by: Fam Zheng <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |