|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 19/20] block: do not abuse EMEDIUMTYPE |
Date: | Mon, 10 Feb 2014 10:01:52 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Il 10/02/2014 09:47, Fam Zheng ha scritto:
> @@ -449,7 +449,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags, > > if (header.magic != QCOW_MAGIC) { > error_setg(errp, "Image is not in qcow2 format");It might be good to have a consistent message pattern in qcow2 as others.
Right, I'll fix the others.
Is it worth adding a QERR_ error class for unexpected format magic?
We're not adding QERR_ anymore, but if anyone has ideas I can do something to improve the homogeneity of the errors.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |