[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: Include iov.h in checksum.h
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] net: Include iov.h in checksum.h |
Date: |
Mon, 10 Feb 2014 11:20:34 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Feb 07, 2014 at 08:54:00AM +0100, Alexander Graf wrote:
>
>
> > Am 07.02.2014 um 08:05 schrieb Michael Tokarev <address@hidden>:
> >
> > 06.02.2014 19:30, Alexander Graf wrote:
> >> The checksum calculation header exports a function that refers to struct
> >> iov which is defined in iov.h. Include the header so that the compiler
> >> knows what this struct is about.
> >
> > Alternatively (and I sometimes prefer it this way), one can just
> > declare `struct iovec;' instead of including whole header, because
> > we don't actually use any definitions from there, and users of
> > checksum.h wont be including extra dependencies which they don't
> > use... Like this:
>
> Either way works for me :)
Yes, please take one of them via -trivial.
Stefan