Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

[Paolo Bonzini]

Il 11/02/2014 00:30, Laszlo Ersek ha scritto:
> > > However, I don't see the point in having the "format-option" field. What
> > > about:
> > >
> > > -> { "execute": "query-dump-guest-memory-capabilities" }
> > > <- { "return": { "formats":
> > >           ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"] }
> Technically you might be right. However, this partial introspection
> feature is entirely a wart

I don't see it entirely like that.  For example, whether paging is 
supported could also be part of the capabilities and not part of the 
regular QAPI introspection.  Of course, quiaonuohan need not add 
anything like that.

> whose existence is exclusively justified by
> non-technical reasons, such as deadlines, and not wanting to be blocked
> indefinitely by architecture astronautics around full introspection. I
> don't see the point of polishing it beyond bare usability, at least not
> after I've reviewed three versions of the patchset.

Luiz, can you apply patches 1-12 for now?  I agree with Laszlo that, no 
matter how unfortunate this is, the "unused" warnings are a necessary 
evil and one that can be worked around easily when bisecting.

Paolo