[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH target-arm v1 7/7] dma/pl330: implement dmaadnh inst
From: |
Peter Crosthwaite |
Subject: |
[Qemu-devel] [PATCH target-arm v1 7/7] dma/pl330: implement dmaadnh instruction |
Date: |
Mon, 10 Feb 2014 22:32:07 -0800 |
Implement the missing DMAADNH instruction. This is a minor variant
of the DMAADDH instruction, so factor out to a common implementation
for both (dmaadxh).
Signed-off-by: Peter Crosthwaite <address@hidden>
---
hw/dma/pl330.c | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
index fe437cb..7acb2c4 100644
--- a/hw/dma/pl330.c
+++ b/hw/dma/pl330.c
@@ -601,10 +601,12 @@ static inline void pl330_fault(PL330Chan *ch, uint32_t
flags)
* LEN - number of elements in ARGS array
*/
-static void pl330_dmaaddh(PL330Chan *ch, uint8_t opcode, uint8_t *args, int
len)
+static void pl330_dmaadxh(PL330Chan *ch, uint8_t *args, bool ra, bool neg)
{
- uint16_t im = (((uint16_t)args[1]) << 8) | ((uint16_t)args[0]);
- uint8_t ra = (opcode >> 1) & 1;
+ uint32_t im = (((uint16_t)args[1]) << 8) | ((uint16_t)args[0]);
+ if (neg) {
+ im |= 0xffff << 16;
+ }
if (ch->is_manager) {
pl330_fault(ch, PL330_FAULT_UNDEF_INSTR);
@@ -617,6 +619,16 @@ static void pl330_dmaaddh(PL330Chan *ch, uint8_t opcode,
uint8_t *args, int len)
}
}
+static void pl330_dmaaddh(PL330Chan *ch, uint8_t opcode, uint8_t *args, int
len)
+{
+ pl330_dmaadxh(ch, args, extract32(opcode, 1, 1), false);
+}
+
+static void pl330_dmaadnh(PL330Chan *ch, uint8_t opcode, uint8_t *args, int
len)
+{
+ pl330_dmaadxh(ch, args, extract32(opcode, 1, 1), true);
+}
+
static void pl330_dmaend(PL330Chan *ch, uint8_t opcode,
uint8_t *args, int len)
{
@@ -1042,6 +1054,7 @@ static void pl330_dmawmb(PL330Chan *ch, uint8_t opcode,
/* NULL terminated array of the instruction descriptions. */
static const PL330InsnDesc insn_desc[] = {
{ .opcode = 0x54, .opmask = 0xFD, .size = 3, .exec = pl330_dmaaddh, },
+ { .opcode = 0x5c, .opmask = 0xFD, .size = 3, .exec = pl330_dmaadnh, },
{ .opcode = 0x00, .opmask = 0xFF, .size = 1, .exec = pl330_dmaend, },
{ .opcode = 0x35, .opmask = 0xFF, .size = 2, .exec = pl330_dmaflushp, },
{ .opcode = 0xA0, .opmask = 0xFD, .size = 6, .exec = pl330_dmago, },
--
1.8.5.4
- [Qemu-devel] [PATCH target-arm v1 0/7] PL330 Changes, Peter Crosthwaite, 2014/02/11
- [Qemu-devel] [PATCH target-arm v1 1/7] dma/pl330: Delete overly verbose debug printf, Peter Crosthwaite, 2014/02/11
- [Qemu-devel] [PATCH target-arm v1 2/7] dma/pl330: Fix misleading type, Peter Crosthwaite, 2014/02/11
- [Qemu-devel] [PATCH target-arm v1 3/7] dma/pl330: printf format type sweep., Peter Crosthwaite, 2014/02/11
- [Qemu-devel] [PATCH target-arm v1 4/7] dma/pl330: Rename parent_obj, Peter Crosthwaite, 2014/02/11
- [Qemu-devel] [PATCH target-arm v1 5/7] dma/pl330: Add event debugging printfs, Peter Crosthwaite, 2014/02/11
- [Qemu-devel] [PATCH target-arm v1 6/7] dma/pl330: Fix buffer depth, Peter Crosthwaite, 2014/02/11
- [Qemu-devel] [PATCH target-arm v1 7/7] dma/pl330: implement dmaadnh instruction,
Peter Crosthwaite <=
- Re: [Qemu-devel] [PATCH target-arm v1 0/7] PL330 Changes, Peter Maydell, 2014/02/12