qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-cap


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command
Date: Tue, 11 Feb 2014 08:19:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

Il 11/02/2014 03:47, Luiz Capitulino ha scritto:
On Tue, 11 Feb 2014 00:34:37 +0100
Paolo Bonzini <address@hidden> wrote:

Il 11/02/2014 00:30, Laszlo Ersek ha scritto:
However, I don't see the point in having the "format-option" field. What
about:

-> { "execute": "query-dump-guest-memory-capabilities" }
<- { "return": { "formats":
          ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"] }
Technically you might be right. However, this partial introspection
feature is entirely a wart

I don't see it entirely like that.  For example, whether paging is
supported could also be part of the capabilities and not part of the
regular QAPI introspection.  Of course, quiaonuohan need not add
anything like that.

whose existence is exclusively justified by
non-technical reasons, such as deadlines, and not wanting to be blocked
indefinitely by architecture astronautics around full introspection. I
don't see the point of polishing it beyond bare usability, at least not
after I've reviewed three versions of the patchset.

Luiz, can you apply patches 1-12 for now?  I agree with Laszlo that, no
matter how unfortunate this is, the "unused" warnings are a necessary
evil and one that can be worked around easily when bisecting.

Yes, I can. But what's the problem with patch 13? For me having Eric's
ACK is enough for applying it. Anything else will be done by QMP
introspection.

I'm suggesting another, more streamlined format; see above.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]