qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/16] target-i386: cleanup 'foo=val' feature ha


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 02/16] target-i386: cleanup 'foo=val' feature handling
Date: Tue, 11 Feb 2014 07:14:17 -0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Nov 27, 2013 at 11:28:42PM +0100, Igor Mammedov wrote:
> features family, model, stepping, level, hv_spinlocks are treated similarly
> when passed from command line, so it's not necessary to handle each of them
> individually. Collapse them to one catch-all branch which will treat
> any not explicitly handled feature in format 'foo=val'.
> 
> PS:
> Any unknown feature will be rejected by property setter so there is no
> need to check for unknown feature in cpu_x86_parse_featurestr(), therefore
> it's replaced by above mentioned catch-all handler.
> 
> Signed-off-by: Igor Mammedov <address@hidden>

Reviewed-by: Eduardo Habkost <address@hidden>

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]