[Qemu-devel] [Bug 1279257] [NEW] [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is always false.

[dcb]

Public bug reported:

Source code is

       } else if ((buf[1] & 4) == 1) {

Suggest code rework. I found this bug by running
static analyser cppcheck over the source code.

I also checked the latest code on the web and the
bug exists there also.

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1279257

Title:
  [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is
  always false.

Status in QEMU:
  New

Bug description:
  Source code is

         } else if ((buf[1] & 4) == 1) {

  Suggest code rework. I found this bug by running
  static analyser cppcheck over the source code.

  I also checked the latest code on the web and the
  bug exists there also.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1279257/+subscriptions