qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Bug 1279257] [NEW] [hw/scsi/scsi-bus.c:910]: (style) E


From: Markus Armbruster
Subject: Re: [Qemu-devel] [Bug 1279257] [NEW] [hw/scsi/scsi-bus.c:910]: (style) Expression '(X & 0x4) == 0x1' is always false.
Date: Wed, 12 Feb 2014 12:01:02 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

dcb <address@hidden> writes:

> Public bug reported:
>
> Source code is
>
>        } else if ((buf[1] & 4) == 1) {
>
> Suggest code rework. I found this bug by running
> static analyser cppcheck over the source code.
>
> I also checked the latest code on the web and the
> bug exists there also.
>
> ** Affects: qemu
>      Importance: Undecided
>          Status: New

Patch is in scsi-next:
https://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg04066.html



reply via email to

[Prev in Thread] Current Thread [Next in Thread]