[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg |
Date: |
Wed, 12 Feb 2014 12:50:59 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/12/2014 12:46 PM, Jeff Cody wrote:
> There are a handful of places in the block layer where a failure path
> has a valid -errno value, yet error_setg() is used. Those instances
> should instead use error_setg_errno(), to preserve as much error
> information as possible.
>
> This patch replaces those instances with error_setg_errno(), so that
> errno is passed up the stack in the error message.
>
> Reported-By: Kevin Wolf <address@hidden>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> block/mirror.c | 13 +++++++++----
> block/qcow2-snapshot.c | 8 +++++---
> block/vmdk.c | 6 +++---
> 3 files changed, 17 insertions(+), 10 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature