[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V17 07/12] quorum: Add quorum_getlength().
From: |
Benoît Canet |
Subject: |
[Qemu-devel] [PATCH V17 07/12] quorum: Add quorum_getlength(). |
Date: |
Wed, 12 Feb 2014 23:06:34 +0100 |
From: Benoît Canet <address@hidden>
Check that every bs file returns the same length.
Otherwise, return -EIO to disable the quorum and
avoid length discrepancy.
Signed-off-by: Benoit Canet <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block/quorum.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/block/quorum.c b/block/quorum.c
index bfd8e9d..2e54921 100644
--- a/block/quorum.c
+++ b/block/quorum.c
@@ -600,12 +600,38 @@ static BlockDriverAIOCB
*quorum_aio_writev(BlockDriverState *bs,
return &acb->common;
}
+static int64_t quorum_getlength(BlockDriverState *bs)
+{
+ BDRVQuorumState *s = bs->opaque;
+ int64_t result;
+ int i;
+
+ /* check that all file have the same length */
+ result = bdrv_getlength(s->bs[0]);
+ if (result < 0) {
+ return result;
+ }
+ for (i = 1; i < s->num_children; i++) {
+ int64_t value = bdrv_getlength(s->bs[i]);
+ if (value < 0) {
+ return value;
+ }
+ if (value != result) {
+ return -EIO;
+ }
+ }
+
+ return result;
+}
+
static BlockDriver bdrv_quorum = {
.format_name = "quorum",
.protocol_name = "quorum",
.instance_size = sizeof(BDRVQuorumState),
+ .bdrv_getlength = quorum_getlength,
+
.bdrv_aio_readv = quorum_aio_readv,
.bdrv_aio_writev = quorum_aio_writev,
};
--
1.8.3.2
- Re: [Qemu-devel] [PATCH V17 03/12] quorum: Add quorum_aio_writev and its dependencies., (continued)
- [Qemu-devel] [PATCH V17 01/12] quorum: Create quorum.c, add QuorumChildRequest and QuorumAIOCB., Benoît Canet, 2014/02/12
- [Qemu-devel] [PATCH V17 05/12] quorum: Add quorum_aio_readv., Benoît Canet, 2014/02/12
- [Qemu-devel] [PATCH V17 08/12] quorum: Add quorum_invalidate_cache()., Benoît Canet, 2014/02/12
- [Qemu-devel] [PATCH V17 04/12] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify., Benoît Canet, 2014/02/12
- [Qemu-devel] [PATCH V17 12/12] quorum: Add unit test., Benoît Canet, 2014/02/12
- [Qemu-devel] [PATCH V17 07/12] quorum: Add quorum_getlength().,
Benoît Canet <=
- [Qemu-devel] [PATCH V17 10/12] quorum: Implement recursive .bdrv_recurse_is_first_non_filter in quorum., Benoît Canet, 2014/02/12
- [Qemu-devel] [PATCH V17 09/12] quorum: Add quorum_co_flush()., Benoît Canet, 2014/02/12
- [Qemu-devel] [PATCH V17 06/12] quorum: Add quorum mechanism., Benoît Canet, 2014/02/12
- [Qemu-devel] [PATCH V17 11/12] quorum: Add quorum_open() and quorum_close()., Benoît Canet, 2014/02/12
- Re: [Qemu-devel] [PATCH V17 11/12] quorum: Add quorum_open() and quorum_close()., Max Reitz, 2014/02/14