[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v20 04/26] add some QemuOpts functions for repla
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v20 04/26] add some QemuOpts functions for replace work |
Date: |
Wed, 12 Feb 2014 16:31:11 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/11/2014 11:33 PM, Chunyan Liu wrote:
> Add some qemu_opt functions to replace the same functionality of
> QEMUOptionParameter handling.
>
> Signed-off-by: Dong Xu Wang <address@hidden>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
> include/qemu/option.h | 9 +++
> util/qemu-option.c | 134
> +++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 143 insertions(+), 0 deletions(-)
>
> +static void qemu_opt_del(QemuOpt *opt);
> +
> +const char *qemu_opt_get_del(QemuOpts *opts, const char *name)
> +{
> + const char *str = qemu_opt_get(opts, name);
> + QemuOpt *opt = qemu_opt_find(opts, name);
> + if (opt) {
> + qemu_opt_del(opt);
Is it any more efficient to reduce the number of times you crawl through
the list? For example, instead of crawling the list with qemu_opt_get,
why not get teh string directly from the result of qemu_opt_find? Also,
you crawl again for qemu_opt_del. Maybe it's unavoidable, and certainly
still O(n), so not the end of the world, but worth thinking about.
> +void qemu_opts_print_help(QemuOptsList *list)
> +{
> + int i;
> + printf("Supported options:\n");
Why printf? Might there be callers that want to print to somewhere
other than stdout?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v20 00/26] replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/02/12
- [Qemu-devel] [PATCH v20 02/26] qapi: output def_value_str when query command line options, Chunyan Liu, 2014/02/12
- [Qemu-devel] [PATCH v20 04/26] add some QemuOpts functions for replace work, Chunyan Liu, 2014/02/12
- Re: [Qemu-devel] [PATCH v20 04/26] add some QemuOpts functions for replace work,
Eric Blake <=
- [Qemu-devel] [PATCH v20 03/26] improve some functions in qemu-option.c, Chunyan Liu, 2014/02/12
- [Qemu-devel] [PATCH v20 05/26] remove assertion of qemu_opt_get functions, Chunyan Liu, 2014/02/12
- [Qemu-devel] [PATCH v20 01/26] add def_value_str to QemuOptDesc, Chunyan Liu, 2014/02/12
- [Qemu-devel] [PATCH v20 06/26] change block layer to support both QemuOpts and QEMUOptionParameter, Chunyan Liu, 2014/02/12