Re: [Qemu-devel] [PATCH v3] vl: convert -m to QemuOpts

[Laszlo Ersek]

On 02/13/14 18:45, Eric Blake wrote:
> On 02/13/2014 09:13 AM, Igor Mammedov wrote:
>> Adds option to -m
>>  "mem" - startup memory amount
>>
>> For compatibility with legacy CLI if suffix-less number is passed,
>> it assumes amount in MiB.
>>
>> Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
>>
>> Signed-off-by: Igor Mammedov <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> v3:
>>  - fixes suggested by Eric Blake <address@hidden>
>>   - check for empty string in more efficient way
>>   - fix MB/MiB inconsistency
>>   - use EXIT_FAILURE instead of 1
>>   - add missing exit() if overflow occurres
> 
> Reviewed-by: Eric Blake <address@hidden>

Me too:

Reviewed-by: Laszlo Ersek <address@hidden>